netdev - Re: [PATCH v2 net] ionic: fix ptp support config breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 May 2021 23:13:59 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Leon Romanovsky <leon@...nel.org>,
        Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        drivers@...sando.io
Subject: Re: [PATCH v2 net] ionic: fix ptp support config breakage

On 5/4/21 10:32 PM, Leon Romanovsky wrote:
> On Tue, May 04, 2021 at 05:00:59PM -0700, Shannon Nelson wrote:
>> Driver link failed with undefined references in some
>> kernel config variations.
>>
>> v2 - added Fixes tag
> 
> Changelogs should be below "---" line.
> We don't need them in commit message history.
> 
>>
>> Fixes: 61db421da31b ("ionic: link in the new hw timestamp code")
>> Reported-by: kernel test robot <lkp@...el.com>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
>> ---
>>  drivers/net/ethernet/pensando/ionic/Makefile    | 3 +--
>>  drivers/net/ethernet/pensando/ionic/ionic_phc.c | 3 +++
>>  2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/pensando/ionic/Makefile b/drivers/net/ethernet/pensando/ionic/Makefile
>> index 4e7642a2d25f..61c40169cb1f 100644
>> --- a/drivers/net/ethernet/pensando/ionic/Makefile
>> +++ b/drivers/net/ethernet/pensando/ionic/Makefile
>> @@ -5,5 +5,4 @@ obj-$(CONFIG_IONIC) := ionic.o
>>  
>>  ionic-y := ionic_main.o ionic_bus_pci.o ionic_devlink.o ionic_dev.o \
>>  	   ionic_debugfs.o ionic_lif.o ionic_rx_filter.o ionic_ethtool.o \
>> -	   ionic_txrx.o ionic_stats.o ionic_fw.o
>> -ionic-$(CONFIG_PTP_1588_CLOCK) += ionic_phc.o
>> +	   ionic_txrx.o ionic_stats.o ionic_fw.o ionic_phc.o
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_phc.c b/drivers/net/ethernet/pensando/ionic/ionic_phc.c
>> index a87c87e86aef..30c78808c45a 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_phc.c
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_phc.c
>> @@ -1,6 +1,8 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  /* Copyright(c) 2017 - 2021 Pensando Systems, Inc */
>>  
>> +#if IS_ENABLED(CONFIG_PTP_1588_CLOCK)
> 
> I'm not sure, but think that IS_ENABLED() is intended to be used inside
> functions/macros as boolean expression.
> 
> For other places like this, "#if CONFIG_PTP_1588_CLOCK" is better fit.

s/#if/#ifdef/

but the patch looks OK to me as is.

-- 
~Randy