netdev - Re: [RFC PATCH v1 1/9] net: phy: micrel: move phy reg offsets to common header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 May 2021 14:24:31 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        kernel@...gutronix.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>
Subject: Re: [RFC PATCH v1 1/9] net: phy: micrel: move phy reg offsets to
 common header

> +#define PHY_REG_CTRL			0

MII_BMCR

> +
> +#define PHY_RESET			BIT(15)
> +#define PHY_LOOPBACK			BIT(14)
> +#define PHY_SPEED_100MBIT		BIT(13)
> +#define PHY_AUTO_NEG_ENABLE		BIT(12)
> +#define PHY_POWER_DOWN			BIT(11)
> +#define PHY_MII_DISABLE			BIT(10)
> +#define PHY_AUTO_NEG_RESTART		BIT(9)
> +#define PHY_FULL_DUPLEX			BIT(8)
> +#define PHY_COLLISION_TEST_NOT		BIT(7)

All the above appear to be standard BMCR bits. Please use the existing
#defines in include/uapi/linux/mii.h

> +#define PHY_HP_MDIX			BIT(5)
> +#define PHY_FORCE_MDIX			BIT(4)
> +#define PHY_AUTO_MDIX_DISABLE		BIT(3)
> +#define PHY_REMOTE_FAULT_DISABLE	BIT(2)
> +#define PHY_TRANSMIT_DISABLE		BIT(1)
> +#define PHY_LED_DISABLE			BIT(0)

Since you are moving into a global scope header, please add a device
prefix.

> +
> +#define PHY_REG_STATUS			1

MII_BMSR

> +
> +#define PHY_100BT4_CAPABLE		BIT(15)
> +#define PHY_100BTX_FD_CAPABLE		BIT(14)
> +#define PHY_100BTX_CAPABLE		BIT(13)
> +#define PHY_10BT_FD_CAPABLE		BIT(12)
> +#define PHY_10BT_CAPABLE		BIT(11)
> +#define PHY_MII_SUPPRESS_CAPABLE_NOT	BIT(6)
> +#define PHY_AUTO_NEG_ACKNOWLEDGE	BIT(5)
> +#define PHY_REMOTE_FAULT		BIT(4)
> +#define PHY_AUTO_NEG_CAPABLE		BIT(3)
> +#define PHY_LINK_STATUS			BIT(2)
> +#define PHY_JABBER_DETECT_NOT		BIT(1)
> +#define PHY_EXTENDED_CAPABILITY		BIT(0)

These also look to be pretty standard BMSR defines.

> +
> +#define PHY_REG_ID_1			2
> +#define PHY_REG_ID_2			3

MII_PHYSID1 & MII_PHYSID2

Please remove everything which directly matches the existing defines.
Just add defines for bits which don't follow 802.3 c22.

     Andrew