[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <162031260998.15077.2780875998395041358.git-patchwork-notify@kernel.org>
Date: Thu, 06 May 2021 14:50:09 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Andrea Claudi <aclaudi@...hat.com>
Cc: netdev@...r.kernel.org, stephen@...workplumber.org,
dsahern@...il.com
Subject: Re: [PATCH iproute2] tc: q_ets: drop dead code from argument parsing
Hello:
This patch was applied to iproute2/iproute2-next.git (refs/heads/main):
On Sat, 1 May 2021 18:44:35 +0200 you wrote:
> Checking for nbands to be at least 1 at this point is useless. Indeed:
> - ets requires "bands", "quanta" or "strict" to be specified
> - if "bands" is specified, nbands cannot be negative, see parse_nbands()
> - if "strict" is specified, nstrict cannot be negative, see
> parse_nbands()
> - if "quantum" is specified, nquanta cannot be negative, see
> parse_quantum()
> - if "bands" is not specified, nbands is set to nstrict+nquanta
> - the previous if statement takes care of the case when none of them are
> specified and nbands is 0, terminating execution.
>
> [...]
Here is the summary with links:
- [iproute2] tc: q_ets: drop dead code from argument parsing
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=a2f1f66075c8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists