netdev - Re: [PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210506174516.aiuuhu7oediqozv4@liuwe-devbox-debian-v2>
Date:   Thu, 6 May 2021 17:45:16 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Michael Kelley <mikelley@...rosoft.com>
Cc:     "Andrea Parri (Microsoft)" <parri.andrea@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "wei.liu@...nel.org" <wei.liu@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to
 generate requestIDs

On Thu, Apr 15, 2021 at 01:22:32PM +0000, Michael Kelley wrote:
> From: Andrea Parri (Microsoft) <parri.andrea@...il.com> Sent: Thursday, April 15, 2021 3:59 AM
> > 
> > Use blk_mq_unique_tag() to generate requestIDs for StorVSC, avoiding
> > all issues with allocating enough entries in the VMbus requestor.
> > 
> > Suggested-by: Michael Kelley <mikelley@...rosoft.com>
> > Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@...il.com>
> > ---
> > Changes since RFC:
> >   - pass sentinel values for {init,reset}_request in vmbus_sendpacket()
> >   - remove/inline the storvsc_request_addr() callback
> >   - make storvsc_next_request_id() 'static'
> >   - add code to handle the case of an unsolicited message from Hyper-V
> >   - other minor/style changes
> > 
> > [1] https://lore.kernel.org/linux-hyperv/20210408161315.341888-1-parri.andrea@gmail.com/
> > 
> >  drivers/hv/channel.c              | 14 ++---
> >  drivers/hv/ring_buffer.c          | 13 +++--
> >  drivers/net/hyperv/netvsc.c       |  8 ++-
> >  drivers/net/hyperv/rndis_filter.c |  2 +
> >  drivers/scsi/storvsc_drv.c        | 94 +++++++++++++++++++++----------
> >  include/linux/hyperv.h            | 13 ++++-
> >  6 files changed, 95 insertions(+), 49 deletions(-)
> 
> LGTM
> 
> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>

Although this patch is tagged with SCSI, I think it would be better if
this goes through the hyperv tree. Let me know if there is any
objection.

Wei.