netdev - Re: [RFC PATCH net-next v3 06/20] net: dsa: qca8k: handle error with qca8k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210506111903.2cczm4cldyqbpnyw@skbuf>
Date:   Thu, 6 May 2021 14:19:03 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Ansuel Smith <ansuelsmth@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH net-next v3 06/20] net: dsa: qca8k: handle error with
 qca8k_write operation

On Wed, May 05, 2021 at 02:47:25AM +0200, Ansuel Smith wrote:
> On Wed, May 05, 2021 at 02:41:24AM +0200, Andrew Lunn wrote:
> > dev_err()
> > 
> > In general, always use dev_err(), dev_warn(), dev_info() etc, so we
> > know which device returned an error.
> >
> 
> I notice that in the driver we use pr function so I assumed this was the
> correct way to report errors with a dsa driver.

Nope.