netdev - Re: [PATCH 1/1] samples: bpf: fix the compiling error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 May 2021 22:13:32 +0800
From:   Zhu Yanjun <zyjzyj2000@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     Zhu Yanjun <yanjun.zhu@...el.com>,
        Mariusz Dudek <mariuszx.dudek@...el.com>,
        Network Development <netdev@...r.kernel.org>,
        Björn Töpel <bjorn@...nel.org>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Subject: Re: [PATCH 1/1] samples: bpf: fix the compiling error

On Thu, May 6, 2021 at 10:04 PM Magnus Karlsson
<magnus.karlsson@...il.com> wrote:
>
> On Thu, May 6, 2021 at 3:51 PM Zhu Yanjun <zyjzyj2000@...il.com> wrote:
> >
> > On Thu, May 6, 2021 at 8:54 PM Magnus Karlsson
> > <magnus.karlsson@...il.com> wrote:
> > >
> > > On Thu, May 6, 2021 at 8:47 AM Zhu Yanjun <yanjun.zhu@...el.com> wrote:
> > > >
> > > > From: Zhu Yanjun <zyjzyj2000@...il.com>
> > > >
> > > > When compiling, the following error will appear.
> > > >
> > > > "
> > > > samples/bpf//xdpsock_user.c:27:10: fatal error: sys/capability.h:
> > > >  No such file or directory
> > > > "
> > >
> > > On my system, I get a compilation error if I include
> > > linux/capability.h as it does not have capget().
> >
> > Thanks. Can you run "rpm -qf /xxx/xxx/sys/capability.h" to check which
> > software provides sys/capability.h?
> > Now I am on CentOS Linux release 8.3.2011.
>
> I do not have CentOS, but it is likely called libcap-dev or
> libcap-devel. If that does not work, Google/Baidu it.

Thanks. On centos8.3, libcap-devel can be installed by "dnf install
libcap-devel".
Then this problem is fixed.

So please ignore this commit.

Zhu Yanjun

>
> > Thanks a lot.
> > Zhu Yanjun
> >
> >
> > >
> > > NAME
> > >        capget, capset - set/get capabilities of thread(s)
> > >
> > > SYNOPSIS
> > >        #include <sys/capability.h>
> > >
> > >        int capget(cap_user_header_t hdrp, cap_user_data_t datap);
> > >
> > > Have you installed libcap? It contains the sys/capability.h header
> > > file that you need.
> > >
> > > > Now capability.h is in linux directory.
> > > >
> > > > Fixes: 3627d9702d78 ("samples/bpf: Sample application for eBPF load and socket creation split")
> > > > Signed-off-by: Zhu Yanjun <zyjzyj2000@...il.com>
> > > > ---
> > > >  samples/bpf/xdpsock_user.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> > > > index aa696854be78..44200aa694cb 100644
> > > > --- a/samples/bpf/xdpsock_user.c
> > > > +++ b/samples/bpf/xdpsock_user.c
> > > > @@ -24,7 +24,7 @@
> > > >  #include <stdio.h>
> > > >  #include <stdlib.h>
> > > >  #include <string.h>
> > > > -#include <sys/capability.h>
> > > > +#include <linux/capability.h>
> > > >  #include <sys/mman.h>
> > > >  #include <sys/resource.h>
> > > >  #include <sys/socket.h>
> > > > --
> > > > 2.27.0
> > > >