netdev - Re: [PATCH iproute2] lib: bpf_legacy: avoid to pass invalid argument to close()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54b95593-ea0e-dd20-ead6-3babab7b42bc@gmail.com>
Date:   Thu, 6 May 2021 08:46:43 -0600
From:   David Ahern <dsahern@...il.com>
To:     Andrea Claudi <aclaudi@...hat.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org
Subject: Re: [PATCH iproute2] lib: bpf_legacy: avoid to pass invalid argument
 to close()

On 5/1/21 11:05 AM, Andrea Claudi wrote:
> In function bpf_obj_open, if bpf_fetch_prog_arg() return an error, we
> end up in the out: path with a negative value for fd, and pass it to
> close.
> 
> Avoid this checking for fd to be positive.
> 
> Fixes: 32e93fb7f66d ("{f,m}_bpf: allow for sharing maps")
> Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> ---
>  lib/bpf_legacy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

applied