netdev - Re: [net-next 4/6] enetc_ptp: support ptp virtual clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202105080457.CX1Y9ku9-lkp@intel.com>
Date:   Sat, 8 May 2021 04:50:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yangbo Lu <yangbo.lu@....com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Yangbo Lu <yangbo.lu@....com>,
        "David S . Miller" <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [net-next 4/6] enetc_ptp: support ptp virtual clock

Hi Yangbo,

I love your patch! Yet something to improve:

[auto build test ERROR on 9d31d2338950293ec19d9b095fbaa9030899dcb4]

url:    https://github.com/0day-ci/linux/commits/Yangbo-Lu/ptp-support-virtual-clocks-for-multiple-domains/20210507-164927
base:   9d31d2338950293ec19d9b095fbaa9030899dcb4
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2df0961abd74b90986d36beeaf4116ed699f232e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yangbo-Lu/ptp-support-virtual-clocks-for-multiple-domains/20210507-164927
        git checkout 2df0961abd74b90986d36beeaf4116ed699f232e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/fsl/ptp_qoriq.h:11,
                    from drivers/net/ethernet/freescale/enetc/enetc_ptp.c:6:
   include/linux/ptp_clock_kernel.h:71:22: error: field 'cc' has incomplete type
      71 |  struct cyclecounter cc;
         |                      ^~
>> drivers/net/ethernet/freescale/enetc/enetc_ptp.c:14:2: error: field name not in record or union initializer
      14 |  .cc.read  = ptp_qoriq_clock_read,
         |  ^
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:14:2: note: (near initialization for 'ptp_qoriq_vclock_cc')
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:15:2: error: field name not in record or union initializer
      15 |  .cc.mask  = CYCLECOUNTER_MASK(64),
         |  ^
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:15:2: note: (near initialization for 'ptp_qoriq_vclock_cc')
>> drivers/net/ethernet/freescale/enetc/enetc_ptp.c:15:14: error: implicit declaration of function 'CYCLECOUNTER_MASK' [-Werror=implicit-function-declaration]
      15 |  .cc.mask  = CYCLECOUNTER_MASK(64),
         |              ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:16:2: error: field name not in record or union initializer
      16 |  .cc.shift  = 28,
         |  ^
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:16:2: note: (near initialization for 'ptp_qoriq_vclock_cc')
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:17:2: error: field name not in record or union initializer
      17 |  .cc.mult  = (1 << 28),
         |  ^
   drivers/net/ethernet/freescale/enetc/enetc_ptp.c:17:2: note: (near initialization for 'ptp_qoriq_vclock_cc')
   cc1: some warnings being treated as errors


vim +14 drivers/net/ethernet/freescale/enetc/enetc_ptp.c

    12	
    13	struct ptp_vclock_cc ptp_qoriq_vclock_cc = {
  > 14		.cc.read		= ptp_qoriq_clock_read,
  > 15		.cc.mask		= CYCLECOUNTER_MASK(64),
    16		.cc.shift		= 28,
    17		.cc.mult		= (1 << 28),
    18		.refresh_interval	= (HZ * 60),
    19		.mult_num		= (1 << 6),
    20		.mult_dem		= 15625,
    21	};
    22	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (70760 bytes)