netdev - Re: [PATCH net] net: ipa: fix inter-EE IRQ register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210506170314.64112387@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 May 2021 17:03:14 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alex Elder <elder@...aro.org>
Cc:     davem@...emloft.net, bjorn.andersson@...aro.org,
        evgreen@...omium.org, cpratapa@...eaurora.org,
        subashab@...eaurora.org, elder@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: ipa: fix inter-EE IRQ register definitions

On Wed,  5 May 2021 17:36:36 -0500 Alex Elder wrote:
> In gsi_irq_setup(), two registers are written with the intention of
> disabling inter-EE channel and event IRQs.
> 
> But the wrong registers are used (and defined); the ones used are
> read-only registers that indicate whether the interrupt condition is
> present.
> 
> Define the mask registers instead of the status registers, and use
> them to disable the inter-EE interrupt types.
> 
> Fixes: 46f748ccaf01 ("net: ipa: explicitly disallow inter-EE interrupts")
> Signed-off-by: Alex Elder <elder@...aro.org>

Applied, thanks!