netdev - Re: [PATCH V4 net] net: stmmac: Fix MAC WoL not working if PHY does not support WoL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210508170529.2b7aedbd@xhacker.debian>
Date:   Sat, 8 May 2021 17:05:29 +0800
From:   Jisheng Zhang <Jisheng.Zhang@...aptics.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "andrew@...n.ch" <andrew@...n.ch>
Cc:     "peppe.cavallaro@...com" <peppe.cavallaro@...com>,
        "alexandre.torgue@...com" <alexandre.torgue@...com>,
        "joabreu@...opsys.com" <joabreu@...opsys.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH V4 net] net: stmmac: Fix MAC WoL not working if PHY does
 not support WoL

On Fri, 7 May 2021 15:46:24 -0700 Jakub Kicinski wrote:


> 
> 
> On Fri, 7 May 2021 10:59:12 +0000 Joakim Zhang wrote:
> > > On Thu,  6 May 2021 13:06:58 +0800 Joakim Zhang wrote:  
> > > > Both get and set WoL will check device_can_wakeup(), if MAC supports
> > > > PMT, it will set device wakeup capability. After commit 1d8e5b0f3f2c ("net:
> > > > stmmac: Support WOL with phy"), device wakeup capability will be
> > > > overwrite in stmmac_init_phy() according to phy's Wol feature. If phy
> > > > doesn't support WoL, then MAC will lose wakeup capability.  
> > >
> > > Let's take a step back. Can we get a minimal fix for losing the config in
> > > stmmac_init_phy(), and then extend the support for WoL for devices which do
> > > support wake up themselves?  
> >
> > Sure, please review the V1, I think this is a minimal fix, then we
> > can extend this as a new feature.

I lost the v1 patch in my email inbox, but I found it by searching it in
web and reviewed v1. If going this way(a minimal fix then make improvements
in net-next) feel free to add below reviewed-by tag for the v1 patch:

Reviewed-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

> 
> Something like that, yes (you can pull the get_wol call into the same
> if block).
> 
> Andrew, would that be acceptable to you? As limited as the either/or
> approach is it should not break any existing users, and the fix needs
> to go to longterm 5.10. We could make the improvements in net-next?
>