netdev - Re: [PATCH iproute2-next] tc: htb: improve burst error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e87317d8-6c43-3a9a-0265-971b1c6a5bcc@gmail.com>
Date:   Sun, 9 May 2021 16:14:23 -0600
From:   David Ahern <dsahern@...il.com>
To:     Andrea Claudi <aclaudi@...hat.com>, netdev@...r.kernel.org
Cc:     stephen@...workplumber.org
Subject: Re: [PATCH iproute2-next] tc: htb: improve burst error messages

On 5/6/21 4:42 AM, Andrea Claudi wrote:
> When a wrong value is provided for "burst" or "cburst" parameters, the
> resulting error message is unclear and can be misleading:
> 
> $ tc class add dev dummy0 parent 1: classid 1:1 htb rate 100KBps burst errtrigger
> Illegal "buffer"
> 
> The message claims an illegal "buffer" is provided, but neither the
> inline help nor the man page list "buffer" among the htb parameters, and
> the only way to know that "burst", "maxburst" and "buffer" are synonyms
> is to look into tc/q_htb.c.
> 
> This commit tries to improve this simply changing the error string to
> the parameter name provided in the user-given command, clearly pointing
> out where the wrong value is.
> 
> $ tc class add dev dummy0 parent 1: classid 1:1 htb rate 100KBps burst errtrigger
> Illegal "burst"
> 
> $ tc class add dev dummy0 parent 1: classid 1:1 htb rate 100Kbps maxburst errtrigger
> Illegal "maxburst"
> 
> Reported-by: Sebastian Mitterle <smitterl@...hat.com>
> Signed-off-by: Andrea Claudi <aclaudi@...hat.com>
> ---
>  tc/q_htb.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 

applied. thanks,