netdev - Re: [PATCH net] net: dsa: fix error code getting shifted with 4 in dsa_slave_get_sset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01a3fd41-5f53-a5fd-ccd6-f65827626ea0@gmail.com>
Date:   Sun, 9 May 2021 18:18:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net] net: dsa: fix error code getting shifted with 4 in
 dsa_slave_get_sset_count



On 5/9/2021 2:54 PM, Vladimir Oltean wrote:
> On Sun, May 09, 2021 at 10:35:27AM -0700, Florian Fainelli wrote:
>> On 5/9/2021 4:55 AM, Vladimir Oltean wrote:
>> I would have a preference for keeping the count variable and treating it
>> specifically in case it is negative.
> 
> Thanks. I hope I've understood you correctly that renaming "err" back to
> "count" was all that you were asking for. Anyway, patch is superseded by
> https://patchwork.kernel.org/project/netdevbpf/patch/20210509193338.451174-1-olteanv@gmail.com/

You did, thanks for the quick spin.
-- 
Florian