netdev - Re: [PATCH] udp: Switch the order of arguments to copy_linear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJqMrZBRu/xwmQkR@casper.infradead.org>
Date:   Tue, 11 May 2021 14:54:53 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Laight <David.Laight@...lab.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "dsahern@...nel.org" <dsahern@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH] udp: Switch the order of arguments to copy_linear_skb

On Tue, May 11, 2021 at 01:44:45PM +0000, David Laight wrote:
> From: Matthew Wilcox
> > Sent: 11 May 2021 14:39
> > 
> > On Tue, May 11, 2021 at 01:11:42PM +0000, David Laight wrote:
> > > From: Matthew Wilcox
> > > > Sent: 11 May 2021 12:34
> > > >
> > > > All other skb functions use (off, len); this is the only one which
> > > > uses (len, off).  Make it consistent.
> > >
> > > I wouldn't change the order of the arguments without some other
> > > change that ensures old code fails to compile.
> > > (Like tweaking the function name.)
> > 
> > Yes, some random essentially internal function that has had no new
> > users since it was created in 2017 should get a new name *eyeroll*.
> > 
> > Please find more useful things to critique.  Or, you know, write some
> > damned code yourself instead of just having opinions.
> 
> You could easily completely screw up any code that isn't committed
> to the kernel source tree.
> It isn't the sort of bug I'd want to diagnose.

Simple, get your kernel driver into the main kernel tree (remember we are
talking about drivers released under a GPL-compatible license here, if your
code doesn't fall under this category, good luck, you are on your own here,
you leech). -- GregKH