netdev - Re: [PATCH] dt-bindings: More removals of type references on common properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2b09c4ed-758d-6eed-8fc1-39653d10e844@lucaceresoli.net>
Date:   Tue, 11 May 2021 16:09:24 +0200
From:   Luca Ceresoli <luca@...aceresoli.net>
To:     Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Olivier Moysan <olivier.moysan@...s.st.com>,
        Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Georgi Djakov <djakov@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Fabrice Gasnier <fabrice.gasnier@...com>,
        Odelu Kukatla <okukatla@...eaurora.org>,
        Alex Elder <elder@...nel.org>,
        Shengjiu Wang <shengjiu.wang@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Input <linux-input@...r.kernel.org>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: More removals of type references on common
 properties

Hi Rob,

On 11/05/21 15:44, Rob Herring wrote:
> On Tue, May 11, 2021 at 2:20 AM Luca Ceresoli <luca@...aceresoli.net> wrote:
>>
>> Hi,
>>
>> On 10/05/21 22:45, Rob Herring wrote:
>>> Users of common properties shouldn't have a type definition as the
>>> common schemas already have one. A few new ones slipped in and
>>> *-names was missed in the last clean-up pass. Drop all the unnecessary
>>> type references in the tree.
>>>
>>> A meta-schema update to catch these is pending.
>>>
>>> Cc: Luca Ceresoli <luca@...aceresoli.net>
>>> Cc: Stephen Boyd <sboyd@...nel.org>
>>> Cc: Olivier Moysan <olivier.moysan@...s.st.com>
>>> Cc: Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>
>>> Cc: Jonathan Cameron <jic23@...nel.org>
>>> Cc: Lars-Peter Clausen <lars@...afoo.de>
>>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
>>> Cc: Georgi Djakov <djakov@...nel.org>
>>> Cc: "David S. Miller" <davem@...emloft.net>
>>> Cc: Jakub Kicinski <kuba@...nel.org>
>>> Cc: Sebastian Reichel <sre@...nel.org>
>>> Cc: Orson Zhai <orsonzhai@...il.com>
>>> Cc: Baolin Wang <baolin.wang7@...il.com>
>>> Cc: Chunyan Zhang <zhang.lyra@...il.com>
>>> Cc: Liam Girdwood <lgirdwood@...il.com>
>>> Cc: Mark Brown <broonie@...nel.org>
>>> Cc: Fabrice Gasnier <fabrice.gasnier@...com>
>>> Cc: Odelu Kukatla <okukatla@...eaurora.org>
>>> Cc: Alex Elder <elder@...nel.org>
>>> Cc: Shengjiu Wang <shengjiu.wang@....com>
>>> Cc: linux-clk@...r.kernel.org
>>> Cc: alsa-devel@...a-project.org
>>> Cc: linux-iio@...r.kernel.org
>>> Cc: linux-arm-kernel@...ts.infradead.org
>>> Cc: linux-input@...r.kernel.org
>>> Cc: linux-pm@...r.kernel.org
>>> Cc: netdev@...r.kernel.org
>>> Signed-off-by: Rob Herring <robh@...nel.org>
>>> ---
>>>  Documentation/devicetree/bindings/clock/idt,versaclock5.yaml    | 2 --
>>>  .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml         | 1 -
>>>  Documentation/devicetree/bindings/input/input.yaml              | 1 -
>>>  Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml   | 1 -
>>>  Documentation/devicetree/bindings/net/qcom,ipa.yaml             | 1 -
>>>  .../devicetree/bindings/power/supply/sc2731-charger.yaml        | 2 +-
>>>  Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml          | 2 +-
>>>  7 files changed, 2 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> index c268debe5b8d..28675b0b80f1 100644
>>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> @@ -60,7 +60,6 @@ properties:
>>>      maxItems: 2
>>>
>>>    idt,xtal-load-femtofarads:
>>> -    $ref: /schemas/types.yaml#/definitions/uint32
>>>      minimum: 9000
>>>      maximum: 22760
>>>      description: Optional load capacitor for XTAL1 and XTAL2
>>> @@ -84,7 +83,6 @@ patternProperties:
>>>          enum: [ 1800000, 2500000, 3300000 ]
>>>        idt,slew-percent:
>>>          description: The Slew rate control for CMOS single-ended.
>>> -        $ref: /schemas/types.yaml#/definitions/uint32
>>>          enum: [ 80, 85, 90, 100 ]
>>
>> Ok, but shouldn't "percent" be listed in
>> Documentation/devicetree/bindings/property-units.txt?
> 
> It is in the schema already[1].

Sure, but having an incomplete file in the kernel is poorly useful, if
not misleading. What about any of these options:

- add to property-units.txt the missing units
- delete property-units.txt from the kernel sources
- replace the entire content of property-units.txt with a link to the
  schema file, stating it is the authoritative and complete source

I would feel a lot better with any of these. I can prepare the patch too.

-- 
Luca