netdev - Re: [PATCH v3 1/1] kernel.h: Split out panic and oops helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6fa5d2c-84e2-2046-19f0-66cf5dd72077@ieee.org>
Date:   Tue, 11 May 2021 09:35:54 -0500
From:   Alex Elder <elder@...e.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-xtensa@...ux-xtensa.org,
        openipmi-developer@...ts.sourceforge.net,
        linux-clk@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-mips@...r.kernel.org,
        linux-parisc@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-um@...ts.infradead.org, linux-hyperv@...r.kernel.org,
        coresight@...ts.linaro.org, linux-leds@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-staging@...ts.linux.dev, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org, linux-arch@...r.kernel.org,
        kexec@...ts.infradead.org, rcu@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v3 1/1] kernel.h: Split out panic and oops helpers

On 5/11/21 2:41 AM, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out panic and
> oops helpers.
> 
> There are several purposes of doing this:
> - dropping dependency in bug.h
> - dropping a loop by moving out panic_notifier.h
> - unload kernel.h from something which has its own domain
> 
> At the same time convert users tree-wide to use new headers, although
> for the time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Acked-by: Mike Rapoport <rppt@...ux.ibm.com>
> Acked-by: Corey Minyard <cminyard@...sta.com>
> Acked-by: Christian Brauner <christian.brauner@...ntu.com>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Kees Cook <keescook@...omium.org>
> Acked-by: Wei Liu <wei.liu@...nel.org>
> Acked-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> Co-developed-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> Acked-by: Sebastian Reichel <sre@...nel.org>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
> Acked-by: Stephen Boyd <sboyd@...nel.org>
> Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Acked-by: Helge Deller <deller@....de> # parisc
> ---
> v3: rebased on top of v5.13-rc1, collected a few more tags
> 
> Note WRT Andrew's SoB tag above: I have added it since part of the cases
> I took from him. Andrew, feel free to amend or tell me how you want me
> to do.
> 

Acked-by: Alex Elder <elder@...nel.org>

. . .

> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index a5f7a79a1923..34b68dc43886 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -8,6 +8,7 @@
>   #include <linux/device.h>
>   #include <linux/interrupt.h>
>   #include <linux/notifier.h>
> +#include <linux/panic_notifier.h>
>   #include <linux/soc/qcom/smem.h>
>   #include <linux/soc/qcom/smem_state.h>
>   

. . .