netdev - Re: [PATCH net] mptcp: fix data stream corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6d8e86b3180679e11f766bd68e8ea207c56a313.camel@redhat.com>
Date:   Tue, 11 May 2021 19:10:39 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Mat Martineau <mathew.j.martineau@...ux.intel.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, mptcp@...ts.linux.dev,
        Maxim Galaganov <max@...ernet.ru>
Subject: Re: [PATCH net] mptcp: fix data stream corruption

On Tue, 2021-05-11 at 09:17 -0700, Mat Martineau wrote:
> On Tue, 11 May 2021, Paolo Abeni wrote:
> 
> > Maxim reported several issues when forcing a TCP transparent proxy
> > to use the MPTCP protocol for the inbound connections. He also
> > provided a clean reproducer.
> > 
> > The problem boils down to 'mptcp_frag_can_collapse_to()' assuming
> > that only MPTCP will use the given page_frag.
> > 
> > If others - e.g. the plain TCP protocol - allocate page fragments,
> > we can end-up re-using already allocated memory for mptcp_data_frag.
> > 
> > Fix the issue ensuring that the to-be-expanded data fragment is
> > located at the current page frag end.
> > 
> > Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/178
> > Reported-and-tested-by: Maxim Galaganov <max@...ernet.ru>
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> > ---
> > net/mptcp/protocol.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> 
> Hi Paolo -
> 
> Should this also have a:
> 
> Fixes: 18b683bff89d ("mptcp: queue data for mptcp level retransmission")
> 
> ?

Indeed! Will send a v2 soon.

Thanks!
Paolo