netdev - Re: [PATCH v4 net] ionic: fix ptp support config breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 11:36:56 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Shannon Nelson <snelson@...sando.io>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org
Cc:     drivers@...sando.io, Allen Hubbe <allenbh@...sando.io>
Subject: Re: [PATCH v4 net] ionic: fix ptp support config breakage

On 5/11/21 11:11 AM, Shannon Nelson wrote:
> When IONIC=y and PTP_1588_CLOCK=m were set in the .config file
> the driver link failed with undefined references.
> 
> We add the dependancy
> 	depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
> to clear this up.
> 
> If PTP_1588_CLOCK=m, the depends limits IONIC to =m (or disabled).
> If PTP_1588_CLOCK is disabled, IONIC can be any of y/m/n.
> 
> Fixes: 61db421da31b ("ionic: link in the new hw timestamp code")
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Allen Hubbe <allenbh@...sando.io>
> Signed-off-by: Shannon Nelson <snelson@...sando.io>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> 
> v4 - Jakub's rewrite
> v3 - put version notes below ---, added Allen's Cc
> v2 - added Fixes tag
> ---
>  drivers/net/ethernet/pensando/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/pensando/Kconfig b/drivers/net/ethernet/pensando/Kconfig
> index 5f8b0bb3af6e..202973a82712 100644
> --- a/drivers/net/ethernet/pensando/Kconfig
> +++ b/drivers/net/ethernet/pensando/Kconfig
> @@ -20,6 +20,7 @@ if NET_VENDOR_PENSANDO
>  config IONIC
>  	tristate "Pensando Ethernet IONIC Support"
>  	depends on 64BIT && PCI
> +	depends on PTP_1588_CLOCK || !PTP_1588_CLOCK
>  	select NET_DEVLINK
>  	select DIMLIB
>  	help
> 


-- 
~Randy