netdev - Re: [PATCH 1/1] b43: phy_n: Delete some useless empty code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1890aa92-ddf2-78f7-51e7-bdc3a58a04c6@huawei.com>
Date:   Tue, 11 May 2021 09:11:27 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        b43-dev <b43-dev@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/1] b43: phy_n: Delete some useless empty code



On 2021/5/11 4:02, Andrew Lunn wrote:
> On Mon, May 10, 2021 at 10:51:17PM +0800, Zhen Lei wrote:
>> These TODO empty code are added by
>> commit 9442e5b58edb ("b43: N-PHY: partly implement SPUR workaround"). It's
>> been more than a decade now. I don't think anyone who wants to perfect
>> this workaround can follow this TODO tip exactly. Instead, it limits them
>> to new thinking. Remove it will be better.
>>
>> No functional change.
> 
> No function change, apart from the new warning?
> 
> Does your bot to compile the change and look for new warnings/errors?

Sorry, I have compiled it. I guess it's probably separated by macros, which I didn't notice. I will check it.

> 
>      Andrew
> 
> .
>