netdev - Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 May 2021 08:09:11 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Zhen Lei <thunder.leizhen@...wei.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, netdev <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

On Mon, May 10, 2021 at 11:00:29AM -0700, Andrii Nakryiko wrote:
> On Mon, May 10, 2021 at 5:43 AM Zhen Lei <thunder.leizhen@...wei.com> wrote:
> >
> > The result of an expression consisting of a single relational operator is
> > already of the bool type and does not need to be evaluated explicitly.
> >
> > No functional change.
> >
> > Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> > ---
> 
> See [0] and [1].
> 
>   [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@mail.gmail.com/
>   [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@mail.gmail.com/

How long do you plan to fight with such patches?

Thanks

> 
> >  tools/lib/bpf/libbpf.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> > index e2a3cf4378140f2..fa02213c451f4d2 100644
> > --- a/tools/lib/bpf/libbpf.c
> > +++ b/tools/lib/bpf/libbpf.c
> > @@ -1504,7 +1504,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val,
> >                                 ext->name, value);
> >                         return -EINVAL;
> >                 }
> > -               *(bool *)ext_val = value == 'y' ? true : false;
> > +               *(bool *)ext_val = value == 'y';
> >                 break;
> >         case KCFG_TRISTATE:
> >                 if (value == 'y')
> > --
> > 2.26.0.106.g9fadedd
> >
> >