netdev - Re: [PATCH net v3] bnxt_en: Fix and improve .ndo_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0UdN+wLGEe0By+2ZiyncXj+nhey-JcproHo5YyXSQBM8XQ@mail.gmail.com>
Date:   Tue, 11 May 2021 17:39:58 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Michael Chan <michael.chan@...adcom.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Andy Gospodarek <gospo@...adcom.com>
Subject: Re: [PATCH net v3] bnxt_en: Fix and improve .ndo_features_check().

On Tue, May 11, 2021 at 4:10 PM Michael Chan <michael.chan@...adcom.com> wrote:
>
> Jakub Kicinski pointed out that we need to handle ipv6 extension headers
> and to explicitly check for supported tunnel types in
> .ndo_features_check().
>
> For ipv6 extension headers, the hardware supports up to 2 ext. headers
> and each must be <= 64 bytes.  For tunneled packets, the supported
> packets are UDP with supported VXLAN and Geneve ports, GRE, and IPIP.
>
> v3: More improvements based on Alexander Duyck's valuable feedback -
>     Remove the jump lable in bnxt_features_check() and restructure it
>     so that the TCP/UDP is check is consolidated in bnxt_exthdr_check().
>
> v2: Add missing step to check inner ipv6 header for UDP and GRE tunnels.
>     Check TCP/UDP next header after skipping ipv6 ext headers for
>     non-tunneled packets and for inner ipv6.
>     (Both feedback from Alexander Duyck)
>
> Reviewed-by: Edwin Peer <edwin.peer@...adcom.com>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> Fixes: 1698d600b361 ("bnxt_en: Implement .ndo_features_check().")
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

This addresses the concerns I had.

Reviewed-by: Alexander Duyck <alexanderduyck@...com>