netdev - Re: [PATCH][v3] rtnetlink: add rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXbigquRvTF6nBM5732i_dPZ7YZX7egdRqtvydiiP-6vw@mail.gmail.com>
Date:   Wed, 12 May 2021 09:15:06 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     "Rocco.Yue" <rocco.yue@...iatek.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-mediatek@...ts.infradead.org, wsd_upstream@...iatek.com
Subject: Re: [PATCH][v3] rtnetlink: add rtnl_lock debug log

On Wed, May 12, 2021 at 1:38 AM Rocco.Yue <rocco.yue@...iatek.com> wrote:
>
> On Tue, 2021-05-11 at 10:00 -0700, Cong Wang wrote:
> > On Tue, May 11, 2021 at 4:46 AM Rocco yue <rocco.yue@...iatek.com> wrote:
> > >
> > > From: Rocco Yue <rocco.yue@...iatek.com>
> > >
> > > We often encounter system hangs caused by certain process
> > > holding rtnl_lock for a long time. Even if there is a lock
> > > detection mechanism in Linux, it is a bit troublesome and
> > > affects the system performance. We hope to add a lightweight
> > > debugging mechanism for detecting rtnl_lock.
> >
> > Any reason why this is specific to RTNL lock? To me holding
> > a mutex lock for a long time is problematic for any mutex.
> > I have seen some fs mutex being held for a long time caused
> > many hung tasks in the system.
> >
> > Thanks.
>
> Thank you for a good question.
>
> It's a problem to hold rtnl_lock for a long time, and other locks are no
> exception.

Then please try to make it generic so that other mutex locks will
benefit too.

Thanks.