netdev - Re: [PATCH] ptp: ocp: Fix a resource leak in an error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210512143620.GE27051@hoboy.vegasvil.org>
Date:   Wed, 12 May 2021 07:36:20 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     kuba@...nel.org, jonathan.lemon@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ptp: ocp: Fix a resource leak in an error handling path

On Wed, May 12, 2021 at 01:15:29PM +0200, Christophe JAILLET wrote:
> If an error occurs after a successful 'pci_ioremap_bar()' call, it must be
> undone by a corresponding 'pci_iounmap()' call, as already done in the
> remove function.
> 
> Fixes: a7e1abad13f3 ("ptp: Add clock driver for the OpenCompute TimeCard.")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Richard Cochran <richardcochran@...il.com>