netdev - Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YJzHqFMitQ7B8weq@unreal>
Date:   Thu, 13 May 2021 09:31:04 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Andrii Nakryiko <andrii.nakryiko@...il.com>
Cc:     Zhen Lei <thunder.leizhen@...wei.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, netdev <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion

On Wed, May 12, 2021 at 12:02:11PM -0700, Andrii Nakryiko wrote:
> On Mon, May 10, 2021 at 10:09 PM Leon Romanovsky <leon@...nel.org> wrote:
> >
> > On Mon, May 10, 2021 at 11:00:29AM -0700, Andrii Nakryiko wrote:
> > > On Mon, May 10, 2021 at 5:43 AM Zhen Lei <thunder.leizhen@...wei.com> wrote:
> > > >
> > > > The result of an expression consisting of a single relational operator is
> > > > already of the bool type and does not need to be evaluated explicitly.
> > > >
> > > > No functional change.
> > > >
> > > > Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>
> > > > ---
> > >
> > > See [0] and [1].
> > >
> > >   [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@mail.gmail.com/
> > >   [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@mail.gmail.com/
> >
> > How long do you plan to fight with such patches?
> 
> As long as necessary. There are better ways to contribute to libbpf
> than doing cosmetic changes to the perfectly correct code.

I wish you good luck with that.

My hope that, you have enough spare time to invest in rejects.

Thanks