netdev - Re: [PATCH net-next 1/2] net: add a napi variant for RT-well-behaved drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 May 2021 02:29:11 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        eric.dumazet@...il.com, simon.horman@...ronome.com,
        oss-drivers@...ronome.com, bigeasy@...utronix.de
Subject: Re: [PATCH net-next 1/2] net: add a napi variant for RT-well-behaved drivers

On Fri, May 14 2021 at 17:21, Jakub Kicinski wrote:
> On Sat, 15 May 2021 02:17:50 +0200 Thomas Gleixner wrote:
>> On Fri, May 14 2021 at 15:24, Jakub Kicinski wrote:
>> >  
>> > +void __napi_schedule_irq(struct napi_struct *n)
>> > +{
>> > +	____napi_schedule(this_cpu_ptr(&softnet_data), n);  
>> 
>> Not that I have any clue, but why does this not need the
>> napi_schedule_prep() check?
>
> napi_schedule_prep() is in the non-__ version in linux/netdevice.h:
>
> static inline void napi_schedule_irq(struct napi_struct *n)
> {
> 	if (napi_schedule_prep(n))
> 		__napi_schedule_irq(n);
> }

I clearly should go to bed now :)