netdev - Re: [PATCH net] netns: export get_net_ns_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YKD8f7wP2EzUU7PX@unreal>
Date:   Sun, 16 May 2021 14:05:35 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "list@...ke-m.de:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        Nicolas Dichtel <nicolas.dichtel@...nd.com>
Subject: Re: [PATCH net] netns: export get_net_ns_by_id()

On Fri, May 14, 2021 at 11:52:51PM +0300, Sergey Ryazanov wrote:
> On Fri, May 14, 2021 at 10:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > On Thu, 13 May 2021 00:29:56 +0300 Sergey Ryazanov wrote:
> > > No one loadable module is able to obtain netns by id since the
> > > corresponding function has not been exported. Export it to be able to
> > > use netns id API in loadable modules too as already done for
> > > peernet2id_alloc().
> >
> > peernet2id_alloc() is used by OvS, what's the user for get_net_ns_by_id()?
> 
> There are currently no active users of get_net_ns_by_id(), that is why
> I did not add a "Fix" tag. Missed function export does not break
> existing code in any way.

It is against kernel rule to do not expose APIs, even internal to the kernel,
without real users. There are many patches every cycle that remove such EXPORT_*()s.

EXPORT_*() creates extra entries in Module.symvers and can be seen as unnecessary
namespace pollution.

Thanks