netdev - Re: [PATCH iproute2 v3] libgenl: make genl_add_mcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 08:44:07 -0600
From:   David Ahern <dsahern@...il.com>
To:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 v3] libgenl: make genl_add_mcast_grp set errno on
 error

On 5/16/21 11:10 PM, Florian Westphal wrote:
> genl_add_mcast_grp doesn't set errno in all cases.
> 
> On kernels that support mptcp but lack event support (all kernels <= 5.11)
> MPTCP_PM_EV_GRP_NAME won't be found and ip will exit with
> 
>     "can't subscribe to mptcp events: Success"
> 
> Set errno to a meaningful value (ENOENT) when the group name isn't found
> and also cover other spots where it returns nonzero with errno unset.
> 
> Fixes: ff619e4fd370 ("mptcp: add support for event monitoring")
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  Change since v2: include errno.h
>  Change since v1: fix libgenl instead of setting errno in the caller.
>  lib/libgenl.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@...nel.org>

It is assigned to Stephen for main branch.