netdev - Re: [PATCH net] tipc: skb_linearize the head skb when reassembling msgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162128461002.31061.4134392433331126815.git-patchwork-notify@kernel.org>
Date:   Mon, 17 May 2021 20:50:10 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Xin Long <lucien.xin@...il.com>
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        davem@...emloft.net, kuba@...nel.org, jmaloy@...hat.com,
        ying.xue@...driver.com
Subject: Re: [PATCH net] tipc: skb_linearize the head skb when reassembling msgs

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat,  8 May 2021 03:57:03 +0800 you wrote:
> It's not a good idea to append the frag skb to a skb's frag_list if
> the frag_list already has skbs from elsewhere, such as this skb was
> created by pskb_copy() where the frag_list was cloned (all the skbs
> in it were skb_get'ed) and shared by multiple skbs.
> 
> However, the new appended frag skb should have been only seen by the
> current skb. Otherwise, it will cause use after free crashes as this
> appended frag skb are seen by multiple skbs but it only got skb_get
> called once.
> 
> [...]

Here is the summary with links:
  - [net] tipc: skb_linearize the head skb when reassembling msgs
    https://git.kernel.org/netdev/net/c/b7df21cf1b79

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html