netdev - Re: [PATCH net] net: wwan: Add WWAN port type attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHNKnsTnbLKXQF2CHEKA-BN9PBAhuY5GYVaTNK5ztjBV4q2zKg@mail.gmail.com>
Date:   Tue, 18 May 2021 02:43:51 +0300
From:   Sergey Ryazanov <ryazanov.s.a@...il.com>
To:     Loic Poulain <loic.poulain@...aro.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        dcbw@...ps.redhat.com, aleksander@...ksander.es
Subject: Re: [PATCH net] net: wwan: Add WWAN port type attribute

Hello Loic,

On Mon, May 17, 2021 at 12:48 PM Loic Poulain <loic.poulain@...aro.org> wrote:
> The port type is by default part of the WWAN port device name.
> However device name can not be considered as a 'stable' API and
> may be subject to change in the future. This change adds a proper
> device attribute that can be used to determine the WWAN protocol/
> type.
>
> Signed-off-by: Loic Poulain <loic.poulain@...aro.org>
> ---
>  drivers/net/wwan/wwan_core.c | 34 +++++++++++++++++++++++++---------
>  1 file changed, 25 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index cff04e5..92a8a6f 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -169,6 +169,30 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
>
>  /* ------- WWAN port management ------- */
>
> +/* Keep aligned with wwan_port_type enum */
> +static const char * const wwan_port_type_str[] = {
> +       "AT",
> +       "MBIM",
> +       "QMI",
> +       "QCDM",
> +       "FIREHOSE"
> +};

A small nitpick, maybe this array should be defined in a such way:

static const char * const wwan_port_type_str[WWAN_PORT_MAX] = {
    [WWAN_PORT_AT] = "AT",
    [WWAN_PORT_MBIM] = "MBIM",
    [WWAN_PORT_QMI] = "QMI",
    [WWAN_PORT_QCDM] = "QCDM",
    [WWAN_PORT_FIREHOSE] = "FIREHOSE",
};

So the array index will be clear without additional notes.

-- 
Sergey