netdev - [PATCH v2] Fix warning due to format mismatch for field width argument to fprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20210517065830.3477-1-heiko.thiery@gmail.com>
Date:   Mon, 17 May 2021 08:58:31 +0200
From:   Heiko Thiery <heiko.thiery@...il.com>
To:     netdev@...r.kernel.org
Cc:     Ben Hutchings <ben@...adent.org.uk>,
        Vasundhara Volam <vasundhara-v.volam@...adcom.com>,
        Andy Gospodarek <gospo@...adcom.com>,
        Edwin Peer <edwin.peer@...adcom.com>,
        Heiko Thiery <heiko.thiery@...il.com>
Subject: [PATCH v2] Fix warning due to format mismatch for field width argument to fprintf()

bnxt.c:66:54: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘unsigned int’ [-Wformat=]
   66 |   fprintf(stdout, "Length is too short, expected 0x%lx\n",
      |                                                    ~~^
      |                                                      |
      |                                                      long unsigned int
      |                                                    %x

Signed-off-by: Heiko Thiery <heiko.thiery@...il.com>
---
v2:
  - use '%zx' since the value is converted to size_t (thanks to Ben)

 bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bnxt.c b/bnxt.c
index b46db72..2b0ac76 100644
--- a/bnxt.c
+++ b/bnxt.c
@@ -63,7 +63,7 @@ int bnxt_dump_regs(struct ethtool_drvinfo *info __maybe_unused, struct ethtool_r
 		return 0;
 
 	if (regs->len < (BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN)) {
-		fprintf(stdout, "Length is too short, expected 0x%lx\n",
+		fprintf(stdout, "Length is too short, expected 0x%zx\n",
 			BNXT_PXP_REG_LEN + BNXT_PCIE_STATS_LEN);
 		return -1;
 	}
-- 
2.30.0