netdev - Re: [PATCH net] netns: export get_net_ns_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6b92c63f-d5eb-7af8-29a7-d8f632654c14@6wind.com>
Date:   Mon, 17 May 2021 09:18:32 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Leon Romanovsky <leon@...nel.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        "list@...ke-m.de:NETWORKING DRIVERS" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] netns: export get_net_ns_by_id()

Le 16/05/2021 à 13:05, Leon Romanovsky a écrit :
> On Fri, May 14, 2021 at 11:52:51PM +0300, Sergey Ryazanov wrote:
>> On Fri, May 14, 2021 at 10:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
>>> On Thu, 13 May 2021 00:29:56 +0300 Sergey Ryazanov wrote:
>>>> No one loadable module is able to obtain netns by id since the
>>>> corresponding function has not been exported. Export it to be able to
>>>> use netns id API in loadable modules too as already done for
>>>> peernet2id_alloc().
>>>
>>> peernet2id_alloc() is used by OvS, what's the user for get_net_ns_by_id()?
>>
>> There are currently no active users of get_net_ns_by_id(), that is why
>> I did not add a "Fix" tag. Missed function export does not break
>> existing code in any way.
> 
> It is against kernel rule to do not expose APIs, even internal to the kernel,
Yep, there was no internal user, it's why I didn't add this EXPORT_*() at the
beginning.


Regards,
Nicolas