netdev - [PATCH] cnic: Fixed double assignment to ictx->xstorm_st

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 17 May 2021 01:49:04 -0700
From:   Javed Hasan <jhasan@...vell.com>
To:     <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <GR-QLogic-Storage-Upstream@...vell.com>,
        <jhasan@...vell.com>
Subject: [PATCH] cnic: Fixed double assignment to ictx->xstorm_st_context.common.flags

	Reported-by: Colin Ian King <colin.king@...onical.com>

diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c
index f7f10cfb3476..d2e8421cc629 100644
--- a/drivers/net/ethernet/broadcom/cnic.c
+++ b/drivers/net/ethernet/broadcom/cnic.c
@@ -1760,7 +1760,7 @@ static int cnic_setup_bnx2x_ctx(struct cnic_dev *dev, struct kwqe *wqes[],
 	}
 	ictx->xstorm_st_context.common.flags =
 		1 << XSTORM_COMMON_CONTEXT_SECTION_PHYSQ_INITIALIZED_SHIFT;
-	ictx->xstorm_st_context.common.flags =
+	ictx->xstorm_st_context.common.flags |=
 		port << XSTORM_COMMON_CONTEXT_SECTION_PBF_PORT_SHIFT;
 
 	ictx->tstorm_st_context.iscsi.hdr_bytes_2_fetch = ISCSI_HEADER_SIZE;
-- 
2.18.2