netdev - Re: [PATCH 2/2 net-next] alx: unlock on error in alx_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42f98bf9dd5919a0bb2184360b3181f68d303fd4.camel@sipsolutions.net>
Date:   Mon, 17 May 2021 11:12:40 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Chris Snook <chris.snook@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2 net-next] alx: unlock on error in
 alx_set_pauseparam()

On Mon, 2021-05-17 at 11:58 +0300, Dan Carpenter wrote:
> We need to drop the lock before returning on this error path.

Haha, how many locking errors can I have in a single patch :(

Sorry, and thanks for all the fixes!

johannes