netdev - Re: [PATCH net-next 2/2] nfp: use napi_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210517094849.GB17134@netronome.com>
Date:   Mon, 17 May 2021 11:48:50 +0200
From:   Simon Horman <simon.horman@...ronome.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, tglx@...utronix.de, netdev@...r.kernel.org,
        eric.dumazet@...il.com, oss-drivers@...ronome.com,
        bigeasy@...utronix.de
Subject: Re: [PATCH net-next 2/2] nfp: use napi_schedule_irq()

On Fri, May 14, 2021 at 03:24:02PM -0700, Jakub Kicinski wrote:
> NFP uses MSI-X and has the most trivial IRQ handler possible.
> Perfect candidate for napi_schedule_irq().
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)


I understand there is some discussion around the merit of PATCH 1/2.
But if that approach is accepted then this patch looks good to me.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>