netdev - Re: [PATCH net-next] net: mdio: provide shim implementation of devm_of_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84619ad5-5b19-a848-a264-baadc75fc65c@gmail.com>
Date:   Tue, 18 May 2021 10:51:25 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <olteanv@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Ansuel Smith <ansuelsmth@...il.com>,
        John Crispin <john@...ozen.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH net-next] net: mdio: provide shim implementation of
 devm_of_mdiobus_register



On 5/18/2021 10:49 AM, Vladimir Oltean wrote:
> Similar to the way in which of_mdiobus_register() has a fallback to the
> non-DT based mdiobus_register() when CONFIG_OF is not set, we can create
> a shim for the device-managed devm_of_mdiobus_register() which calls
> devm_mdiobus_register() and discards the struct device_node *.
> 
> In particular, this solves a build issue with the qca8k DSA driver which
> uses devm_of_mdiobus_register and can be compiled without CONFIG_OF.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>
> Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian