netdev - Re: [PATCH net-next 03/10] ipv4: Add custom multipath hash policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f933d9c-905b-0d2d-d115-90a256a63c01@gmail.com>
Date:   Mon, 17 May 2021 19:42:18 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, petrm@...dia.com,
        roopa@...dia.com, nikolay@...dia.com, ssuryaextr@...il.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next 03/10] ipv4: Add custom multipath hash policy

On 5/17/21 12:15 PM, Ido Schimmel wrote:
> Add a new multipath hash policy where the packet fields used for hash
> calculation are determined by user space via the
> fib_multipath_hash_fields sysctl that was introduced in the previous
> patch.
> 
> The current set of available packet fields includes both outer and inner
> fields, which requires two invocations of the flow dissector. Avoid
> unnecessary dissection of the outer or inner flows by skipping
> dissection if none of the outer or inner fields are required.
> 
> In accordance with the existing policies, when an skb is not available,
> packet fields are extracted from the provided flow key. In which case,
> only outer fields are considered.
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  Documentation/networking/ip-sysctl.rst |   2 +
>  net/ipv4/route.c                       | 121 +++++++++++++++++++++++++
>  net/ipv4/sysctl_net_ipv4.c             |   3 +-
>  3 files changed, 125 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>