netdev - Re: [PATCH net-next 06/10] ipv6: Add a sysctl to control multipath hash fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c17daeb-cc26-852f-01df-ca83ffbb3970@gmail.com>
Date:   Mon, 17 May 2021 19:44:21 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...dia.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, petrm@...dia.com,
        roopa@...dia.com, nikolay@...dia.com, ssuryaextr@...il.com,
        mlxsw@...dia.com
Subject: Re: [PATCH net-next 06/10] ipv6: Add a sysctl to control multipath
 hash fields

On 5/17/21 12:15 PM, Ido Schimmel wrote:
> A subsequent patch will add a new multipath hash policy where the packet
> fields used for multipath hash calculation are determined by user space.
> This patch adds a sysctl that allows user space to set these fields.
> 
> The packet fields are represented using a bitmask and are common between
> IPv4 and IPv6 to allow user space to use the same numbering across both
> protocols. For example, to hash based on standard 5-tuple:
> 
>  # sysctl -w net.ipv6.fib_multipath_hash_fields=0x0037
>  net.ipv6.fib_multipath_hash_fields = 0x0037
> 
> To avoid introducing holes in 'struct netns_sysctl_ipv6', move the
> 'bindv6only' field after the multipath hash fields.
> 
> The kernel rejects unknown fields, for example:
> 
>  # sysctl -w net.ipv6.fib_multipath_hash_fields=0x1000
>  sysctl: setting key "net.ipv6.fib_multipath_hash_fields": Invalid argument
> 
> Signed-off-by: Ido Schimmel <idosch@...dia.com>
> ---
>  Documentation/networking/ip-sysctl.rst | 27 ++++++++++++++++++++++++++
>  include/net/ipv6.h                     |  8 ++++++++
>  include/net/netns/ipv6.h               |  3 ++-
>  net/ipv6/ip6_fib.c                     |  5 +++++
>  net/ipv6/sysctl_net_ipv6.c             | 12 ++++++++++++
>  5 files changed, 54 insertions(+), 1 deletion(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>