netdev - Re: [Patch bpf-next v4 02/12] af_unix: implement ->read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpU5Nw6SkRBQ9XthaQNSwVbqpuUpWNgBRZwj=uzcx=LaBQ@mail.gmail.com>
Date:   Mon, 17 May 2021 21:51:03 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:     bpf <bpf@...r.kernel.org>, Jiang Wang <jiang.wang@...edance.com>,
        Xiongchun Duan <duanxiongchun@...edance.com>,
        Dongdong Wang <wangdongdong.6@...edance.com>,
        Cong Wang <cong.wang@...edance.com>,
        John Fastabend <john.fastabend@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jakub Sitnicki <jakub@...udflare.com>,
        Lorenz Bauer <lmb@...udflare.com>
Subject: Re: [Patch bpf-next v4 02/12] af_unix: implement ->read_sock() for sockmap

On Sat, May 8, 2021 at 3:09 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> +static int unix_read_sock(struct sock *sk, read_descriptor_t *desc,
> +                         sk_read_actor_t recv_actor)
> +{
> +       int copied = 0;
> +
> +       while (1) {
> +               struct unix_sock *u = unix_sk(sk);
> +               struct sk_buff *skb;
> +               int used, err;
> +
> +               mutex_lock(&u->iolock);
> +               skb = skb_recv_datagram(sk, 0, 1, &err);
> +               mutex_unlock(&u->iolock);
> +               if (!skb)
> +                       return err;
> +
> +               used = recv_actor(desc, skb, 0, skb->len);
> +               if (used <= 0) {
> +                       if (!copied)
> +                               copied = used;
> +                       break;
> +               } else if (used <= skb->len) {
> +                       copied += used;
> +               }
> +

Like udp_read_sock(), we should also free the skb here.
I will update this and send V5 soon.

Thanks.