netdev - Re: [PATCH] tls splice: check SPLICE_F_NONBLOCK instead of MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SY4P282MB2854A31945CCBEA39B164CEEA72C9@SY4P282MB2854.AUSP282.PROD.OUTLOOK.COM>
Date:   Tue, 18 May 2021 06:17:13 +0000
From:   Jim Ma <majinjing3@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "borisp@...dia.com" <borisp@...dia.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] tls splice: check SPLICE_F_NONBLOCK instead of
 MSG_DONTWAIT

Thanks for reminder.
I'm sure that, fix patch fixes: c46234ebb4d1 ("tls: RX path for ktls")

 On 2021/5/18, 00:01, "Jakub Kicinski" <kuba@...nel.org> wrote:

    On Sun, 16 May 2021 04:58:11 +0000 Jim Ma wrote:
    > No, this patch fix using MSG_* in splice.
    > 
    > I have tested read, write, sendmsg, recvmsg fot tls, and try to
    > implement tls in golang. In develop, I have found those issues and
    > try to fix them.

    To be clear the Fixes tag points to the commit where the issue was
    first introduced. AFAICT the issue was there from the start, that
    is commit c46234ebb4d1 ("tls: RX path for ktls"). Are you saying that 
    it used to work in the beginning and then another commit broke it?

    We need the fixes tag to be able to tell how far back (in terms of
    LTS releases) to backport.

    > An other issue, when before enable TLS_RX in cleint, the server sends
    > a tls record, client will receive bad message or message too long
    > error. I'm try to fix this issue.

    Please reply all and don't top post.

On 2021/5/15, 03:27, "Jakub Kicinski" <kuba@...nel.org> wrote:

    On Fri, 14 May 2021 11:11:02 +0800 Jim Ma wrote:
    > In tls_sw_splice_read, checkout MSG_* is inappropriate, should use
    > SPLICE_*, update tls_wait_data to accept nonblock arguments instead
    > of flags for recvmsg and splice.
    > 
    > Signed-off-by: Jim Ma <majinjing3@...il.com>

    Fixes: c46234ebb4d1 ("tls: RX path for ktls")

    right?