netdev - [RFC net-next af_unix v1 1/1] net:af_unix: Allow unix sockets to raise SIGURG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210518074343.980438-1-Rao.Shoaib@oracle.com>
Date:   Tue, 18 May 2021 00:43:43 -0700
From:   Rao Shoaib <Rao.Shoaib@...cle.com>
To:     netdev@...r.kernel.org
Cc:     kuba@...nel.org, linux-kernel@...r.kernel.org, davem@...emloft.net,
        matthew.wilcox@...cle.com, rao.shoaib@...cle.com
Subject: [RFC net-next af_unix v1 1/1] net:af_unix: Allow unix sockets to raise SIGURG

From: Rao Shoaib <rao.shoaib@...cle.com>

TCP sockets allow SIGURG to be sent to the process holding the other
end of the socket.  Extend Unix sockets to have the same ability.

The API is the same in that the sender uses sendmsg() with MSG_OOB to
raise SIGURG.  Unix sockets behave in the same way as TCP sockets with
SO_OOBINLINE set.

SIGURG is ignored by default, so applications which do not know about this
feature will be unaffected.  In addition to installing a SIGURG handler,
the receiving application must call F_SETOWN or F_SETOWN_EX to indicate
which process or thread should receive the signal.

Signed-off-by: Rao Shoaib <rao.shoaib@...cle.com>
Signed-off-by: Matthew Wilcox <matthew.wilcox@...cle.com>
---
 net/unix/af_unix.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index 5a31307ceb76..c8400c002882 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -1838,8 +1838,6 @@ static int unix_stream_sendmsg(struct socket *sock, struct msghdr *msg,
 		return err;

 	err = -EOPNOTSUPP;
-	if (msg->msg_flags&MSG_OOB)
-		goto out_err;

 	if (msg->msg_namelen) {
 		err = sk->sk_state == TCP_ESTABLISHED ? -EISCONN : -EOPNOTSUPP;
@@ -1904,6 +1902,9 @@ static int unix_stream_sendmsg(struct socket *sock, struct msghdr *msg,
 		sent += size;
 	}

+	if (msg->msg_flags & MSG_OOB)
+		sk_send_sigurg(other);
+
 	scm_destroy(&scm);

 	return sent;
-- 
2.31.1