netdev - Re: [PATCH net-next] cipso: correct comments of cipso_v4_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhTuiHXGRmW3Rs=6k6PJagpq=rxX5E8nDW2puAZVzb4xbQ@mail.gmail.com>
Date:   Tue, 18 May 2021 10:46:28 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Zheng Yejian <zhengyejian1@...wei.com>
Cc:     netdev@...r.kernel.org, zhangjinhao2@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net-next] cipso: correct comments of cipso_v4_cache_invalidate()

On Tue, May 18, 2021 at 5:05 AM Zheng Yejian <zhengyejian1@...wei.com> wrote:
>
> Since cipso_v4_cache_invalidate() has no return value, so drop
> related descriptions in its comments.
>
> Fixes: 446fda4f2682 ("[NetLabel]: CIPSOv4 engine")
> Signed-off-by: Zheng Yejian <zhengyejian1@...wei.com>
> ---
>  net/ipv4/cipso_ipv4.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks for catching this.

Acked-by: Paul Moore <paul@...l-moore.com>

> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index bfaf327e9d12..d6e3a92841e3 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -187,8 +187,7 @@ static int __init cipso_v4_cache_init(void)
>   * cipso_v4_cache_invalidate - Invalidates the current CIPSO cache
>   *
>   * Description:
> - * Invalidates and frees any entries in the CIPSO cache.  Returns zero on
> - * success and negative values on failure.
> + * Invalidates and frees any entries in the CIPSO cache.
>   *
>   */
>  void cipso_v4_cache_invalidate(void)
> --
> 2.17.1

-- 
paul moore
www.paul-moore.com