netdev - Re: [PATCH bpf-next 03/11] bpfilter: Add IO functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 11:47:32 -0700
From:   Song Liu <song@...nel.org>
To:     Dmitrii Banshchikov <me@...que.spb.ru>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, Andrey Ignatov <rdna@...com>
Subject: Re: [PATCH bpf-next 03/11] bpfilter: Add IO functions

On Tue, May 18, 2021 at 11:06 PM Dmitrii Banshchikov <me@...que.spb.ru> wrote:
>
> Introduce IO functions for:
> 1) reading and writing data from a descriptor: read_exact(), write_exact(),
> 2) reading and writing memory of other processes: pvm_read(), pvm_write().
>
> read_exact() and write_exact() are wrappers over read(2)/write(2) with
> correct handling of partial read/write. These functions are intended to
> be used for communication over pipe with the kernel part of bpfilter.
>
> pvm_read() and pvm_write() are wrappers over
> process_vm_readv(2)/process_vm_writev(2) with an interface that uses a
> single buffer instead of vectored form. These functions are intended to
> be used for readining/writing memory buffers supplied to iptables ABI
> setsockopt(2) from other processes.
>
> Signed-off-by: Dmitrii Banshchikov <me@...que.spb.ru>

The code looks correct, so

Acked-by: Song Liu <songliubraving@...com>

However, I am not sure whether we really want these wrapper functions.

[...]