netdev - Re: [PATCH] net: phy: add driver for Motorcomm yt8511 phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 May 2021 11:18:10 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Peter Geis <pgwipeout@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH] net: phy: add driver for Motorcomm yt8511 phy

On Tue, May 18, 2021 at 08:20:03PM -0400, Peter Geis wrote:
> On Tue, May 18, 2021 at 4:59 AM Leon Romanovsky <leon@...nel.org> wrote:
> >
> > On Tue, May 11, 2021 at 05:46:06PM -0400, Peter Geis wrote:
> > > Add a driver for the Motorcomm yt8511 phy that will be used in the
> > > production Pine64 rk3566-quartz64 development board.
> > > It supports gigabit transfer speeds, rgmii, and 125mhz clk output.
> > >
> > > Signed-off-by: Peter Geis <pgwipeout@...il.com>
> > > ---
> > >  MAINTAINERS                 |  6 +++
> > >  drivers/net/phy/Kconfig     |  6 +++
> > >  drivers/net/phy/Makefile    |  1 +
> > >  drivers/net/phy/motorcomm.c | 85 +++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 98 insertions(+)
> > >  create mode 100644 drivers/net/phy/motorcomm.c
> >
> > <...>
> >
> > > +static const struct mdio_device_id __maybe_unused motorcomm_tbl[] = {
> > > +     { PHY_ID_MATCH_EXACT(PHY_ID_YT8511) },
> > > +     { /* sentinal */ }
> > > +}
> >
> > Why is this "__maybe_unused"? This *.c file doesn't have any compilation option
> > to compile part of it.
> >
> > The "__maybe_unused" is not needed in this case.
> 
> I was simply following convention, for example the realtek.c,
> micrel.c, and smsc.c drivers all have this as well.

Maybe they have a reason, but this specific driver doesn't have such.

Thanks

> 
> >
> > Thanks