netdev - Re: [PATCH bpf-next 00/11] bpfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7312CC5D-510B-4BFD-8099-BB754FBE9CDF@fb.com>
Date:   Thu, 20 May 2021 04:54:45 +0000
From:   Song Liu <songliubraving@...com>
To:     Dmitrii Banshchikov <me@...que.spb.ru>
CC:     "open list:BPF (Safe dynamic programs and tools)" 
        <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>, Martin Lau <kafai@...com>,
        "Yonghong Song" <yhs@...com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Andrey Ignatov <rdna@...com>
Subject: Re: [PATCH bpf-next 00/11] bpfilter



> On May 17, 2021, at 3:52 PM, Dmitrii Banshchikov <me@...que.spb.ru> wrote:
> 
> The patchset is based on the patches from David S. Miller [1] and Daniel
> Borkmann [2].
> 
> The main goal of the patchset is to prepare bpfilter for iptables'
> configuration blob parsing and code generation.
> 
> The patchset introduces data structures and code for matches, targets, rules
> and tables.
> 
> It seems inconvenient to continue to use the same blob internally in bpfilter
> in parts other than the blob parsing. That is why a superstructure with native
> types is introduced. It provides a more convenient way to iterate over the blob
> and limit the crazy structs widespread in the bpfilter code.
> 

[...]

> 
> 
> 1. https://lore.kernel.org/patchwork/patch/902785/

[1] used bpfilter_ prefix on struct definitions, like "struct bpfilter_target"
I think we should do the same in this version. (Or were there discussions on
removing the prefix?). 

Thanks,
Song

[...]