netdev - Re: [PATCH RDS/TCP v1 1/1] RDS tcp loopback connection can hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2354795f-25d7-14d4-2e2f-3fc5ec22cc90@oracle.com>
Date:   Fri, 21 May 2021 14:37:03 -0700
From:   Shoaib Rao <rao.shoaib@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH RDS/TCP v1 1/1] RDS tcp loopback connection can hang


On 5/21/21 2:25 PM, David Miller wrote:
> From: Rao Shoaib <Rao.Shoaib@...cle.com>
> Date: Fri, 21 May 2021 11:08:06 -0700
>
>> +				/* No transport currently in use
>> +				 * should end up here, but if it
>> +				 * does, reset/destroy the connection.
>> +				 */
>> +				kmem_cache_free(rds_conn_slab, conn);
>> +				conn = ERR_PTR(-EOPNOTSUPP);
>> +				goto out;
> Is thosa all we have to do?  What about releasing c_path[]?
>
> Thanks.

rds_connection object is created before c_paths are populated. The code 
is killing the creation of rds_connection object, so there are no paths 
to free.

Thanks,

Shoaib