netdev - Re: [RFC v2 00/23] io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a83f147b-ea9d-e693-a2e9-c6ce16659749@gmail.com>
Date:   Fri, 21 May 2021 01:58:59 +0100
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Song Liu <songliubraving@...com>
Cc:     "io-uring@...r.kernel.org" <io-uring@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Horst Schirmeier <horst.schirmeier@...dortmund.de>,
        "Franz-B . Tuneke" <franz-bernhard.tuneke@...dortmund.de>,
        Christian Dietrich <stettberger@...ucode.de>
Subject: Re: [RFC v2 00/23] io_uring BPF requests

On 5/21/21 1:35 AM, Song Liu wrote:
>> On May 19, 2021, at 7:13 AM, Pavel Begunkov <asml.silence@...il.com> wrote:
>> The main problem solved is feeding completion information of other
>> requests in a form of CQEs back into BPF. I decided to wire up support
>> for multiple completion queues (aka CQs) and give BPF programs access to
>> them, so leaving userspace in control over synchronisation that should
>> be much more flexible that the link-based approach.
>>
>> For instance, there can be a separate CQ for each BPF program, so no
>> extra sync is needed, and communication can be done by submitting a
>> request targeting a neighboring CQ or submitting a CQE there directly
>> (see test3 below). CQ is choosen by sqe->cq_idx, so everyone can
>> cross-fire if willing.
>>
> 
> [...]
> 
>>  bpf: add IOURING program type
>>  io_uring: implement bpf prog registration
>>  io_uring: add support for bpf requests
>>  io_uring: enable BPF to submit SQEs
>>  io_uring: enable bpf to submit CQEs
>>  io_uring: enable bpf to reap CQEs
>>  libbpf: support io_uring
>>  io_uring: pass user_data to bpf executor
>>  bpf: Add bpf_copy_to_user() helper
>>  io_uring: wire bpf copy to user
>>  io_uring: don't wait on CQ exclusively
>>  io_uring: enable bpf reqs to wait for CQs
> 
> Besides the a few comments, these BPF related patches look sane to me. 
> Please consider add some selftests (tools/testing/selftests/bpf). 

The comments are noted. Thanks Song

-- 
Pavel Begunkov