netdev - Re: [Linuxarm] [PATCH RFC v4 0/3] Some optimization for lockless qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210521141406.mmxv4ikfp4zfkcwo@skbuf>
Date:   Fri, 21 May 2021 17:14:06 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     davem@...emloft.net, kuba@...nel.org, a.fatoum@...gutronix.de,
        vladimir.oltean@....com, ast@...nel.org, daniel@...earbox.net,
        andriin@...com, edumazet@...gle.com, weiwan@...gle.com,
        cong.wang@...edance.com, ap420073@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...neuler.org, mkl@...gutronix.de,
        linux-can@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, bpf@...r.kernel.org,
        jonas.bonn@...rounds.com, pabeni@...hat.com, mzhivich@...mai.com,
        johunt@...mai.com, albcamus@...il.com, kehuan.feng@...il.com,
        atenart@...nel.org, alexander.duyck@...il.com, hdanton@...a.com,
        jgross@...e.com, JKosina@...e.com, mkubecek@...e.cz,
        bjorn@...nel.org, alobakin@...me
Subject: Re: [Linuxarm] [PATCH RFC v4 0/3] Some optimization for lockless
 qdisc

On Thu, May 20, 2021 at 04:46:52PM +0300, Vladimir Oltean wrote:
> Hi Yunsheng,
> 
> On Thu, May 20, 2021 at 05:45:14PM +0800, Yunsheng Lin wrote:
> > On 2021/5/20 17:27, Yunsheng Lin wrote:
> > > Patch 1: remove unnecessary seqcount operation.
> > > Patch 2: implement TCQ_F_CAN_BYPASS.
> > > Patch 3: remove qdisc->empty.
> > > 
> > > RFC v4: Use STATE_MISSED and STATE_DRAINING to indicate non-empty
> > >         qdisc, and add patch 1 and 3.
> > 
> > @Vladimir, Ahmad
> > It would be good to run your testcase to see if there are any
> > out of order for this version, because this version has used
> > STATE_MISSED and STATE_DRAINING to indicate non-empty qdisc,
> > thanks.
> > 
> > It is based on newest net branch with qdisc stuck patchset.
> > 
> > Some performance data as below:
> > 
> > pktgen + dummy netdev:
> >  threads  without+this_patch   with+this_patch      delta
> >     1       2.60Mpps            3.18Mpps             +22%
> >     2       3.84Mpps            5.72Mpps             +48%
> >     4       5.52Mpps            5.52Mpps             +0.0%
> >     8       2.77Mpps            2.81Mpps             +1.4%
> >    16       2.24Mpps            2.29Mpps             +2.2%
> > 
> > IP forward testing: 1.05Mpps increases to 1.15Mpps
> 
> I will start the regression test with the flexcan driver on LS1028A and
> let you know tomorrow or so if there is any TX reordering issue.

14 million CAN frames later, I did not observe any TX reordering at all.