netdev - Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210523061221.GD29015@dragon>
Date:   Sun, 23 May 2021 14:12:22 +0800
From:   Shawn Guo <shawn.guo@...aro.org>
To:     Arend van Spriel <arend.vanspriel@...adcom.com>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        Rafał Miłecki <rafal@...ecki.pl>,
        Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Chi-hsien Lin <chi-hsien.lin@...ineon.com>,
        Wright Feng <wright.feng@...ineon.com>,
        Chung-hsien Hsu <chung-hsien.hsu@...ineon.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com
Subject: Re: [PATCH] brcmfmac: use ISO3166 country code and 0 rev as fallback

On Wed, Apr 28, 2021 at 08:42:29PM +0800, Shawn Guo wrote:
> On Wed, Apr 28, 2021 at 02:03:07PM +0200, Arend van Spriel wrote:
> > On 4/25/2021 1:02 PM, Shawn Guo wrote:
> > > Instead of aborting country code setup in firmware, use ISO3166 country
> > > code and 0 rev as fallback, when country_codes mapping table is not
> > > configured.  This fallback saves the country_codes table setup for recent
> > > brcmfmac chipsets/firmwares, which just use ISO3166 code and require no
> > > revision number.
> > 
> > I am somewhat surprised, but with the brcm-spinoffs (cypress/infineon and
> > synaptics) my understanding may have been surpassed by reality. Would you
> > happen to know which chipsets/firmwares require only ISO3166 code and no
> > rev?
> 
> The "no rev" here actually means 'rev' field being zero.  The chipset
> I'm running is a BCM43012 from Synaptics, I think.
> 
> Firmware: BCM43012/2 wl0: Apr 16 2021 15:25:36 version 18.35.389.63.t2 (wlan=r836194) FWID 01-a8c7bac

Arend,

Does it make sense?  Or is there actually a country code mapping table
I'm not aware of?

Shawn