netdev - Re: [PATCH net] net: zero-initialize skb extensions on allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210524171316.GB3194@breakpoint.cc>
Date:   Mon, 24 May 2021 19:13:16 +0200
From:   Florian Westphal <fw@...len.de>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     Florian Westphal <fw@...len.de>, davem@...emloft.net,
        kuba@...nel.org, pablo@...filter.org,
        mathew.j.martineau@...ux.intel.com, matthieu.baerts@...sares.net,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        saeedm@...lanox.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: zero-initialize skb extensions on allocation

Vlad Buslov <vladbu@...dia.com> wrote:
> So what would you suggest: provide a dedicated wrapper for TC skb
> extension that will memset resulting extension to zero or refactor my
> patch to zero-initialize specific skb extension in skb_ext_add() (only
> the extension requested and also when previously discarded extension is
> reused)?

I would go for A), but if you prefer B) I would not mind.