netdev - Re: [PATCH bpf-next] xsk: use kvcalloc to support large umems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 May 2021 10:59:12 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>
Cc:     "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Netdev <netdev@...r.kernel.org>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        bpf <bpf@...r.kernel.org>, Dan Siemon <dan@...erfire.com>
Subject: Re: [PATCH bpf-next] xsk: use kvcalloc to support large umems

Björn Töpel wrote:
> On Fri, 21 May 2021 at 10:33, Magnus Karlsson <magnus.karlsson@...il.com> wrote:
> >
> > From: Magnus Karlsson <magnus.karlsson@...el.com>
> >
> > Use kvcalloc() instead of kcalloc() to support large umems with, on my
> > server, one million pages or more in the umem.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
> > Reported-by: Dan Siemon <dan@...erfire.com>
> 
> Nice!
> 
> Acked-by: Björn Töpel <bjorn@...nel.org>

LGTM as well. I scanned the driver side, thinking there might be
some complication there, but looks like it handles this fine.

Acked-by: John Fastabend <john.fastabend@...il.com>