netdev - Re: [PATCH v2] bpftool: Add sock_release help info for cgroup attach command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8b76c9d-9d92-4b46-eaa3-ba2ba546f91f@isovalent.com>
Date:   Mon, 24 May 2021 09:23:17 +0100
From:   Quentin Monnet <quentin@...valent.com>
To:     Liu Jian <liujian56@...wei.com>, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, kafai@...com,
        songliubraving@...com, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v2] bpftool: Add sock_release help info for cgroup attach
 command

2021-05-24 16:03 UTC+0800 ~ Liu Jian <liujian56@...wei.com>
> The help information is not added when the function is added.
> Add the missing help information.
> 
> Fixes: db94cc0b4805 ("bpftool: Add support for BPF_CGROUP_INET_SOCK_RELEASE")
> Signed-off-by: Liu Jian <liujian56@...wei.com>
> ---
> v1 -> v2:
>     Add changelog text.
> 
>  tools/bpf/bpftool/cgroup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c
> index d901cc1b904a..6e53b1d393f4 100644
> --- a/tools/bpf/bpftool/cgroup.c
> +++ b/tools/bpf/bpftool/cgroup.c
> @@ -28,7 +28,8 @@
>  	"                        connect6 | getpeername4 | getpeername6 |\n"   \
>  	"                        getsockname4 | getsockname6 | sendmsg4 |\n"   \
>  	"                        sendmsg6 | recvmsg4 | recvmsg6 |\n"           \
> -	"                        sysctl | getsockopt | setsockopt }"
> +	"                        sysctl | getsockopt | setsockopt |\n"	       \
> +	"                        sock_release }"
>  
>  static unsigned int query_flags;
>  
> 

Thanks a lot!

Note that there are a few other places in bpftool where the attach point
should be added, would you mind updating them too? That would be: the
documentation page for bpftool-cgroup, the one for bpftool-prog, the
help message in prog.c, and the bash completion. It should all be
straightforward. You can try something like "grep recvmsg4
tools/bpf/bpftool" to find the relevant locations.

Best regards,
Quentin